F/index transactions cost #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlc is right to change GetVote's Date from Time to NullTime, which is a nullable form to tell us whether or not there is a value, since we use a LEFT JOIN on the blocks table to get the block time. If there is no such block, the LEFT JOIN leaves the block time as null. In this case, just like with the transaction hash, we do not care, so we use the time.Time even if it is zero and thus invalid.
p4u
force-pushed
the
f/index_transactions_cost
branch
from
7e0ab6f
to
4c886a9
Compare
mvdan
approved these changes
Sep 7, 2023
p4u
force-pushed
the
f/index_transactions_cost
branch
from
4c886a9
to
d47fe5c
Compare
1. /chain/fees/page/{page}
2. /chain/fees/reference/{reference}/page/{page}
3. /chain/fees/type/{type}/page/{page}
4. /accounts/{accountID}/fees/page/{page}
Signed-off-by: p4u <[email protected]>
p4u
force-pushed
the
f/index_transactions_cost
branch
from
d47fe5c
to
66aa095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info vocdoni/interoperability#84