add mongodb implementation for the db package #1089
Conversation
p4u
force-pushed
the
f/add_mongo_as_kv
branch
3 times, most recently
from
c83dc63
to
fbebe9c
Compare
p4u
force-pushed
the
f/add_mongo_as_kv
branch
3 times, most recently
from
f2bc278
to
34650cd
Compare
db/mongodb/mongodb.go
Outdated
|
|
||
| filter := bson.M{} | ||
| if len(prefix) > 0 { | ||
| filter = bson.M{"_id": bson.M{"$regex": primitive.Regex{Pattern: "^" + string(prefix)}}} |
There was a problem hiding this comment.
I wonder how slow this might be...
There was a problem hiding this comment.
I hope mongo people made it efficient enough :/ But there is not other way, I have been looking for a better (non string regex bassed) mechanism, but there is nothing we can use.
db/mongodb/mongodb.go
Outdated
| primitive.E{Key: "value", Value: v}, | ||
| }}, | ||
| } | ||
| model := mongo.NewUpdateOneModel().SetFilter(bson.D{primitive.E{Key: "_id", Value: string(k)}}).SetUpsert(true).SetUpdate(update) |
There was a problem hiding this comment.
the point of a WriteTx is to bulk/batch writes; why are you using NewUpdateOneModel instead of NewUpdateManyModel? note that I'm not familiar with how mongo works at all, just wondering outloud.
There was a problem hiding this comment.
So the strategy is to accumulate single model updates in the memory batch.
Then on commit, I use collection.BulkWrite() that takes as parameter a list of models to apply.
This is the way it usually works for mongo, at least what I found it in the official docs.
The db interface has now an implementation for mongodb. So instead of pebble a user or consumer of the vocdoni-node API can choose to use mongodb. Its not faster than local KV, but useful when the host runing the database has no persistent storage available, so a remote storage is required. The mongodb url must be set on a env var, such as: MONGODB_URL="mongodb://root:vocdoni@localhost:27017/" go run ./cmd/node -t mongodb -c dev Signed-off-by: p4u <[email protected]>
p4u
force-pushed
the
f/add_mongo_as_kv
branch
from
34650cd
to
fe6e09a
Compare
The db interface has now an implementation for mongodb. So instead of pebble a user or consumer of the vocdoni-node API can choose to use mongodb. Its not faster than local KV, but useful when the host runing the database has no persistent storage available, so a remote storage is required.
The mongodb url must be set on a env var, such as:
MONGODB_URL="mongodb://root:vocdoni@localhost:27017/" go run ./cmd/node -t mongodb -c dev