end2end: update sendVotes to avoid infinite for loop #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@altergui please |
altergui
reviewed
Aug 1, 2023
mariajdab
force-pushed
the
end2endtest/check-errors-from-sendVotes
branch
2 times, most recently
from
83430f5
to
99cea63
Compare
…hen retry count reached the max allowed check the errs in each test that calls sendVotes
mariajdab
force-pushed
the
end2endtest/check-errors-from-sendVotes
branch
from
99cea63
to
cd77535
Compare
|
Ready for re-review @altergui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the approach for send a batch of votes
sendVotesis possible to experiment a infinite for loop, due in some cases the error is handled with a log usinglog.Warn(err)or it is just ignored and continue, in order to prevent the infinite loop a couple of variables was added to count each of those errors and if the count reach the max count allowed, that error is added to the slice of error returned by the method.Also, currently the errs returned by the
sendVotesis not been checked in each test, it was also included in this change.And in the other hand
overwriteVotewas simplified to not usesendVotesas intermediary method, instead just useapi.Voteand check the error once.