Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processes filtering logic #835

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Processes filtering logic #835

merged 4 commits into from
Nov 14, 2024

Conversation

elboletaire
Copy link
Member

@elboletaire elboletaire commented Nov 12, 2024 •
edited
Loading

  • Moved react-query logic for the pagination and filtering to the route's loader method.
  • Due to the above change, the dashboard routes were moved back to the hook, since having them externally would have increase significantly the amount of arguments passed to the function.
  • Updated the sidebar links to point to these new filters.
  • Removed old limit logic in ProcessesList, since we can now limit directly via the API.

What I don't like: the empty processes list layout...

@elboletaire
Add processes pagination filter by status
690bce7 
And updated the sidebar links to point to these new filters
@elboletaire
Remove unused method
ee3e8bf
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

🚀 Deployed on https://6734ba47fa76a106e8427c40--vocdoni-app-stg.netlify.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

🚀 Deployed on https://6734ba4ac420830c261c4cae--vocdoni-app-dev.netlify.app

@github-actions github-actions bot temporarily deployed to pull request November 12, 2024 16:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 12, 2024 16:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 12, 2024 16:37 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 12, 2024 16:37 Inactive
selankon
selankon requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@selankon selankon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works like a charm! I suggested some minor changes

src/queries/organization.ts Outdated Show resolved Hide resolved
src/queries/organization.ts Show resolved Hide resolved
src/router/routes/dashboard.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 14:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 13, 2024 14:40 Inactive
@elboletaire elboletaire merged commit 8b50bb2 into develop Nov 14, 2024
3 checks passed
@elboletaire elboletaire deleted the f/filtered-processes branch November 14, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selankon selankon selankon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elboletaire @selankon