-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jailing git commands makes bwrap complain about GNUPG related path parameters #216
Comments
@Hs-Yeah Hi, thanks for raising the issue! My bad (insufficient testing). I need to understand how to fix it. I'm not 100% sure that the override you're referring is the culprit (reason of the failure). I think it has been working for a while already (setting $HOME to /dev/null as recommended in If you've built |
I can build |
Temporary revert version 0.19.8 until issue #216 has been fixed vn971/rua#216 This reverts commit 08ecca2.
@Hs-Yeah From my current understanding, the conflict is because the commit you reference eaa5910 introduces jailing for all git invocations, and the jailing script is this one: https://github.com/vn971/rua/blob/master/res/wrapper/security-wrapper.sh |
Yes, and as my |
On the other hand, the line 84 (that sets $HOME to /dev/null) is needed exclusively to avoid messing up with people's local git configurations (or rather, avoid being messed up by people's local git configurations). If, however, Will test it now. |
Just for a background info if anyone might be interested. I've decided to start jailing TL&DR; Might be an overkill, but cleaner this way. |
See #216, in particular #216 (comment) and #216 (comment) With this commit, git invocations by `rua` should be safe even in presence of arbitrary .gitattributes files, and should not be disrupted by people's local git configurations.
This should fix the issue: #217 |
|
@Hs-Yeah Thanks! And thanks again for reporting! |
Oh, sorry for the false reporting, I ran the wrong command ( With the aforementioned line removed, a new error shows up:
|
Can confirm 0.19.9 fix this issue. @vn971 Thank you for the quick response and quick fix! |
When I ran
rua install
command after upgraded to 0.19.8, this error popped up:I think this is introduced by commit eaa5910 where $HOME is set to
/dev/null
at line 84 ofgit_utils.rs
.After downgrading to 0.19.7, the error disappeared.
P.S. In my system, $GNUPGHOME is not set:
OS: Arch Linux x86_64
Kernel: 6.5.5-arch1-1
Shell: bash 5.1.16
The text was updated successfully, but these errors were encountered: