Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OVA installer webserver #4365

Merged
merged 2 commits into from
Mar 24, 2017
Merged

Add OVA installer webserver #4365

merged 2 commits into from
Mar 24, 2017

Conversation

andrewtchin
Copy link
Contributor

Fixes #4254

On the launched installer VM:

root@localhost [ ~ ]# ls /data/fileserver/
LICENSE  README  appliance.iso  bootstrap.iso  com.vmware.vic-0.9.0.zip  com.vmware.vic.ui-0.9.0.zip  vic-machine-linux  vic-ui-darwin  vic-ui-linux  vic-ui-windows.exe
root@localhost [ ~ ]# ls /usr/local/bin/
docker-compose  ova-webserver
root@localhost [ ~ ]# /usr/local/bin/ova-webserver
INFO[0000] Current UID/GID = 0/0                        
INFO[0000] Generating self signed certificate           
INFO[0000] Loaded certificate                           
INFO[0000] Starting server on :8443 

root@localhost [ ~ ]# curl -k https://192.168.1.40:8443
<pre>
<a href="LICENSE">LICENSE</a>
<a href="README">README</a>
<a href="appliance.iso">appliance.iso</a>
<a href="bootstrap.iso">bootstrap.iso</a>
<a href="com.vmware.vic-0.9.0.zip">com.vmware.vic-0.9.0.zip</a>
<a href="com.vmware.vic.ui-0.9.0.zip">com.vmware.vic.ui-0.9.0.zip</a>
<a href="vic-machine-linux">vic-machine-linux</a>
<a href="vic-ui-darwin">vic-ui-darwin</a>
<a href="vic-ui-linux">vic-ui-linux</a>
<a href="vic-ui-windows.exe">vic-ui-windows.exe</a>
</pre>
root@localhost [ ~ ]# curl -k -Lo /tmp/vic-machine-linux https://192.168.1.40:8443/vic-machine-linux
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 17.9M  100 17.9M    0     0   222M      0 --:--:-- --:--:-- --:--:--  224M
root@localhost [ ~ ]# ls /tmp
systemd-private-a2d6cd95b9c7433ab5446b3522f5aa1a-systemd-timesyncd.service-rxUjHp  vic-machine-linux  vmware-root
root@localhost [ ~ ]# chmod +x /tmp/vic-machine-linux 
root@localhost [ ~ ]# /tmp/vic-machine-linux 
NAME:
   vic-machine-linux - Create and manage Virtual Container Hosts

USAGE:
   vic-machine-linux [global options] command [command options] [arguments...]

VERSION:
   v0.9.0-0-7897de1

COMMANDS:
     create   Deploy VCH
     delete   Delete VCH and associated resources
     ls       List VCHs
     inspect  Inspect VCH
     upgrade  Upgrade VCH to latest version
     version  Show VIC version information
     debug    Debug VCH
     update   Modify configuration
     help, h  Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --help, -h     show help
   --version, -v  print the version

frapposelli
frapposelli approved these changes Mar 23, 2017
View reviewed changes
Copy link
Member

@frapposelli frapposelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

installer/fileserver/server.go
ud := syscall.Getuid()
gd := syscall.Getgid()
log.Info(fmt.Sprintf("Current UID/GID = %d/%d", ud, gd))
/* TODO FIXME
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue for this and reference before merging

frapposelli
frapposelli requested changes Mar 24, 2017
View reviewed changes
Copy link
Member

@frapposelli frapposelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, very minor nit but it's to keep consistency

installer/fileserver/server.go Outdated
}
*/

flag.StringVar(&conf.addr, "addr", ":8443", "Listen address - must include host and port (addr:port)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it :9443 by default

@frapposelli frapposelli merged commit 254aa95 into vmware:master Mar 24, 2017
@andrewtchin andrewtchin deleted the 4254/ova-webserver branch March 24, 2017 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frapposelli frapposelli frapposelli approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewtchin @frapposelli @vmwclabot