Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container page #676

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Fix container page #676

merged 3 commits into from
Aug 6, 2019

Conversation

zhoumeina
Copy link
Contributor

@zhoumeina zhoumeina commented Aug 6, 2019

for container tab page not working.
Upgrade clarity from 0.12 to 0.13

Signed-off-by: Meina Zhou <[email protected]>
@zhoumeina zhoumeina force-pushed the fix_container_page branch from 06188fa to 151e674 Compare August 6, 2019 07:17
@codecov-io
Copy link

codecov-io commented Aug 6, 2019

Codecov Report

Merging #676 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
+ Coverage   65.96%   65.98%   +0.01%     
==========================================
  Files          61       61              
  Lines        2918     2919       +1     
  Branches      517      519       +2     
==========================================
+ Hits         1925     1926       +1     
  Misses        691      691              
  Partials      302      302
Impacted Files Coverage Δ
.../vic-webapp/src/app/vch-view/vch-view.component.ts 50.34% <0%> (+0.34%) ⬆️
...p/create-vch-wizard/create-vch-wizard.component.ts 23.3% <100%> (-0.38%) ⬇️
...ebapp/src/app/services/mocks/container.response.ts 83.33% <100%> (ø) ⬆️
...src/app/container-view/container-view.component.ts 72.63% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71e28bf...151e674. Read the comment docs.

Copy link
Contributor

@jwangyangls jwangyangls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@zhoumeina zhoumeina merged commit 04964fd into vmware:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants