Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding thumbprints validation logging improvements #451

Conversation

lmalvins
Copy link
Contributor

Fixes #425

PR acceptance checklist:

[X] All unit tests pass
[X ] All e2e tests pass
[ ] Unit test(s) included*
[ ] e2e test(s) included*
[ ] Screenshot attached and UX approved*

*if applicable, add n/a if not

@lmalvins
Copy link
Contributor Author

Part of the log for success thumbprint validation:

[2018-04-24T22:19:43.505-03:00] [INFO ] data-service-pool-15 70000071 100002 200001 com.vmware.utils.ssl.ThumbprintTrustManager expected one of this thumbprints: [3a326de252c79979872d14b11826fe8ec12e509e] actual thumbprint: [3a326de252c79979872d14b11826fe8ec12e509e]...thumbprints matching ok!

Part of the log for failed thumbprint validation:

[2018-04-24T22:40:55.525-03:00] [ERROR] data-service-pool-96 70000218 100002 200001 com.vmware.utils.ssl.ThumbprintTrustManager Server certificate chain is not trusted and thumbprint doesn't match, expected one of this [3a326de252c79979872d14b11826fe8ec12e509e] actual: [3a326de252c79979872d14b11826fe8ec12e509eee]

@codecov-io
Copy link

Codecov Report

Merging #451 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #451   +/-   ##
======================================
  Coverage    66.8%   66.8%           
======================================
  Files          60      60           
  Lines        2711    2711           
  Branches      477     477           
======================================
  Hits         1811    1811           
  Misses        612     612           
  Partials      288     288
Impacted Files Coverage Δ
...p/create-vch-wizard/create-vch-wizard.component.ts 22.88% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a5d4d...36f4a88. Read the comment docs.

@jak-atx jak-atx merged commit da43a71 into vmware:master May 3, 2018
lmalvins added a commit to lmalvins/vic-ui that referenced this pull request May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants