Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with empty and or duplicated nodes on resource tree selector #448

Merged
merged 1 commit into from
May 3, 2018

Conversation

javierfz1980
Copy link
Contributor

Fix issue with empty and or duplicated nodes on resource tree selector of vch creation wizard

Fixes #441

PR acceptance checklist:

[ x ] All unit tests pass
[ x ] All e2e tests pass
[ n/a ] Unit test(s) included*
[ n/a ] e2e test(s) included*
[ n/a ] Screenshot attached and UX approved*

Screenshots attached of before and after for multivc and singlevc:

singlevc structure:
singlevc-441-structure

singlevc before this fix:
singlevc-441-before

singlevc after this fix:
singlevc-441-after

multivc structure:
multivc-441-structure

multivc before this fix:
multivc-441-before

multivc after this fix:
multivc-441-after

@codecov-io
Copy link

Codecov Report

Merging #448 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #448   +/-   ##
======================================
  Coverage    66.8%   66.8%           
======================================
  Files          60      60           
  Lines        2711    2711           
  Branches      477     477           
======================================
  Hits         1811    1811           
  Misses        612     612           
  Partials      288     288

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b05ee3...c356392. Read the comment docs.

@javierfz1980 javierfz1980 self-assigned this Apr 23, 2018
@jak-atx jak-atx merged commit a7d5d5b into vmware:master May 3, 2018
javierfz1980 added a commit to javierfz1980/vic-ui that referenced this pull request May 18, 2018
javierfz1980 added a commit that referenced this pull request May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When cluster on vc is empty (with nothing inside) the cluster is showed up with no name in Creation Wizard
4 participants