vdk-core: execution result missing exception and blamee fix #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The execution result was sometimes and sometimes not provisioned with the exception in case such is known. It was also lacking information about blamee, yet interfacing unclassified (raw) exceptions. Therefore, the information about error classification was not present in ExecutionResult, only in StepResult (design flaw). Also, data job execution summary was not referring to the exception dynamically (via getter), that was prone to non-initialized exception. Improved the `ExecutionResult` design by elaborating on blamee alongside a raw-or-not-raw exception. Fixed the rest of the ExecutionResult initialization implementation so that in all the cases the exception is known, then it is populated. Refined the data job execution summary by adding exception_name and blamee in case of job failure. Testing Done: Test-fixed expectation about a non-populated exception in ExecutionResult, and added blamee check. Updated tests to using `get_exception_to_raise()` in favour of the deprecated `get_exception()`. Signed-off-by: ikoleva <[email protected]>
doks5
approved these changes
Aug 11, 2022
The execution result was sometimes and sometimes not provisioned with the exception in case such is known. It was also lacking information about blamee, yet interfacing unclassified (raw) exceptions. Therefore, the information about error classification was not present in ExecutionResult, only in StepResult (design flaw). Also, data job execution summary was not referring to the exception dynamically (via getter), that was prone to non-initialized exception. Improved the `ExecutionResult` design by elaborating on blamee alongside a raw-or-not-raw exception. Fixed the rest of the ExecutionResult initialization implementation so that in all the cases the exception is known, then it is populated. Refined the data job execution summary by adding exception_name and blamee in case of job failure. Testing Done: Test-fixed expectation about a non-populated exception in ExecutionResult, and added blamee check. Updated tests to using `get_exception_to_raise()` in favour of the deprecated `get_exception()`. Signed-off-by: ikoleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The execution result was sometimes and sometimes not provisioned with
the exception in case such is known. It was also lacking information
about blamee, yet interfacing unclassified (raw) exceptions.
Therefore, the information about error classification was not present
in ExecutionResult, only in StepResult (design flaw).
Also, data job execution summary was not referring to the exception
dynamically (via getter), that was prone to non-initialized exception.
Improved the
ExecutionResultdesign by elaborating on blamee alongsidea raw-or-not-raw exception. Fixed the rest of the ExecutionResult
initialization implementation so that in all the cases the exception is
known, then it is populated.
Refined the data job execution summary by adding exception_name
and blamee in case of job failure.
Testing Done: Test-fixed expectation about a non-populated exception
in ExecutionResult, and added blamee check.
Updated tests to using
get_exception_to_raise()in favour of thedeprecated
get_exception().Signed-off-by: ikoleva [email protected]