vdk-core: hide native cursor from execute hook #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current design was allowing users to access directly native cursor unwrapped which defeat the purpose of being on data/control path of queries as Iva correctly pointed out in earlier review. It was necessary because user need to be able to invoke native vendor specific methods (like get_profile of impala cursor). But there's better approach where both users are allowed to call vendor specific methods yet keep certain methods (like execute) curated/wrapped by VDK. It's by introducing ProxyCursor (which is moving some functionalith of ManagedCursor). Testing Done: existing tests passed. I added explicit functional test to test the proxying functionality Signed-off-by: Antoni Ivanov <[email protected]>
doks5
approved these changes
Jun 23, 2022
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/execution_cursor.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/execution_cursor.py
Outdated
Show resolved
Hide resolved
projects/vdk-core/src/vdk/internal/builtin_plugins/connection/managed_cursor.py
Outdated
Show resolved
Hide resolved
…execution_cursor.py
…execution_cursor.py Co-authored-by: Andy <[email protected]>
…managed_cursor.py Co-authored-by: Andy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current design was allowing users to access directly native cursor
unwrapped which defeat the purpose of being on data/control path of
queries as Iva correctly pointed out in earlier review.
It was necessary because user need to be able to invoke native vendor
specific methods (like get_profile of impala cursor).
But there's better approach where both users are allowed to call vendor
specific methods yet keep certain methods (like execute) curated/wrapped
by VDK. It's by introducing ProxyCursor (which is moving some
functionalith of ManagedCursor).
Testing Done: existing tests passed. I added explicit functional test to
test the proxying functionality
Signed-off-by: Antoni Ivanov [email protected]