vdk-core: detect non vdk_ prefixed environment values for config #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently user need to set VDK_ + config name as environment variable so VDK can recognize it. The idea was to avoid conflicts with similarly named env variables. But this proved to be very error prone where users tend to forget or get confused on where vdk_ prefix is needed and where it is not. This is solved by allowing non-prefixed env variable to be set. For for configuration "team" Now if "VDK_TEAM" is set as environment variable is set it is used (as before) If it is not set but "TEAM" is set as env variable, it is now used. Prefixed variables do have higher priority. Testing Done: unit test Signed-off-by: Antoni Ivanov <[email protected]>
antoniivanov
commented
Jun 22, 2022
projects/vdk-core/tests/vdk/internal/builtin_plugins/config/test_vdk_config.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently user need to set VDK_ + config name as environment variable so
VDK can recognize it. The idea was to avoid conflicts with similarly
named env variables. But this proved to be very error prone where users
tend to forget or get confused on where vdk_ prefix is needed and where
it is not.
This is solved by allowing non-prefixed env variable to be set.
For for configuration "team"
Now if "VDK_TEAM" is set as environment variable is set it is used (as
before)
If it is not set but "TEAM" is set as env variable, it is now used.
Prefixed variables do have higher priority.
Testing Done: unit test
Signed-off-by: Antoni Ivanov [email protected]