Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdk-oracle: remove secrets config in favour of secrets overrides from vdk-core #3156

Closed
DeltaMichael opened this issue Feb 22, 2024 · 0 comments
Closed

vdk-oracle: remove secrets config in favour of secrets overrides from vdk-core #3156

DeltaMichael opened this issue Feb 22, 2024 · 0 comments
Assignees
@duyguHsnHsn
Labels
enhancement New feature or request initiative: VDK Oracle VDK Oracle support story Task for an Epic
Milestone
VDK Oracle

Comments

@DeltaMichael
Copy link
Contributor

Follow-up from #1722

Overview

We should remove https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-plugins/vdk-oracle/src/vdk/plugin/oracle/oracle_plugin.py#L39 because it will be pulled from secrets anyway after #1722 is implemented.

Acceptance criteria

  1. Remove the secrets override in vdk-oracle and rely on secrets fetched by vdk-core
@DeltaMichael DeltaMichael added the enhancement New feature or request label Feb 22, 2024
@DeltaMichael DeltaMichael added this to the VDK Oracle milestone Feb 22, 2024
@DeltaMichael DeltaMichael added the story Task for an Epic label Feb 22, 2024
@stefan-pulov stefan-pulov added the initiative: VDK Oracle VDK Oracle support label Mar 6, 2024
@DeltaMichael DeltaMichael mentioned this issue Mar 6, 2024
Merged
@duyguHsnHsn duyguHsnHsn mentioned this issue Mar 18, 2024
Merged
@DeltaMichael DeltaMichael mentioned this issue Mar 19, 2024
Closed
duyguHsnHsn added a commit that referenced this issue Mar 22, 2024
@duyguHsnHsn
vdk-oracle: remove secrets override (#3220)
54d510a 
Solving: #3156 

Tested: locally with job runs

Signed-off-by: Duygu Hasan [[email protected]](mailto:[email protected])
yonitoo pushed a commit that referenced this issue Mar 26, 2024
@duyguHsnHsn @yonitoo
vdk-oracle: remove secrets override (#3220)
b6899d8 
Solving: #3156 

Tested: locally with job runs

Signed-off-by: Duygu Hasan [[email protected]](mailto:[email protected])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duyguHsnHsn duyguHsnHsn

Labels
enhancement New feature or request initiative: VDK Oracle VDK Oracle support story Task for an Epic
Projects
None yet
Milestone
VDK Oracle
Development

No branches or pull requests
3 participants
@duyguHsnHsn @DeltaMichael @stefan-pulov