Add support for 'edge_cluster_id' specification in VDC #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
Signed-off-by: Dainius Serplis <[email protected]>
adambarreiro
reviewed
Nov 2, 2022
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
approved these changes
Nov 4, 2022
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
adambarreiro
approved these changes
Nov 8, 2022
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to specify
edge_cluster_idfor NSX-Tvcd_org_vdcresource. This is a prerequisite for DHCP management in NSX-T Isolated networks. Next step will be to alignvcd_nsxt_network_dhcpresource with latest VCD features (issues #907 and #885 are also related to bumping upvcd_nsxt_network_dhcpas VCD functionality was very limited when we introduced it)Note. Field
edge_cluster_idalways works for resources as only a provider user can create VDCs. The data source user might not always have access to read Edge Cluster configuration. For this reason the data source attempts to read value but ignores that error if it got an error in response. (data source doc is also updated with information about behavior of this attribute)Data source
vcd_nsxt_edge_clusterused for Edge Cluster lookup is also improved to support better filtering - previously it was bound to VDC lookup only which wasn't suitable as there is no VDC yet when creatingvcd_org_vdc. Now it supports lookup by different filtering scopes as provided by VCD -vdc_id,vdc_group_idandprovider_vdc_id.Also a new config parameter
nsxtEdgeClusteris introduced to supply tests with existing NSX-T Edge Cluster name.Screenshot of configuration location in UI VCD 10.4.0
Partly related to: