vcd_nsxt_alb_edgegateway_service_engine_group fix when no vdc is specified in provider level
#854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
changed the title
vdc is specified in provider level
Didainius
requested review from
lvirbalas,
dataclouder,
vbauzys,
adambarreiro and
mikeletux
as code owners
vbauzys
approved these changes
May 18, 2022
adambarreiro
approved these changes
May 18, 2022
mikeletux
approved these changes
May 19, 2022
lvirbalas
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #841 adding support for a bunch of resources a bug still persisted in
vcd_nsxt_alb_edgegateway_service_engine_groupdependency on VDC field. This PR adds a test for replication of it (commit 5ae834e) it and introduces a fix (commit 67b4157).Special thanks goes to @adambarreiro for finding it.
Acceptance tests pass on 10.2 and 10.3 using tags
network nsxt vdcGroup albBinary tests passed on 10.2 using tag
alb