Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add independent disk sharing_type missing value #849

Merged
merged 2 commits into from
May 12, 2022

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented May 11, 2022

The independent disk sharing_type property can have two active modes, which are already provided, but there is also an inactive mode (None) which was not recognized by the validation function.

Giuseppe Maxia added 2 commits May 11, 2022 16:06
@dataclouder dataclouder marked this pull request as ready for review May 11, 2022 14:54
@dataclouder dataclouder changed the title Add independent disk sharing type missing value Add independent disk sharing_type missing value May 11, 2022
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tried to create disk with "None" and it worked. Made things simpler :)

Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@dataclouder dataclouder merged commit 0960f9f into vmware:main May 12, 2022
@dataclouder dataclouder deleted the add-missing-disk-sharing-mode branch November 20, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants