Add catalog details represeting properties as computed fields #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeletux
requested review from
lvirbalas,
dataclouder,
Didainius and
vbauzys
as code owners
|
Changelog as well as docs still need to be put in place. |
lvirbalas
approved these changes
Mar 7, 2022
adambarreiro
approved these changes
Mar 7, 2022
terraform-provider-vcd-bot
added
test-running:acc
test-failed:acc
and removed
test-request:acc
test-running:acc
labels
vbauzys
suggested changes
Mar 16, 2022
lvirbalas
approved these changes
Mar 18, 2022
vbauzys
reviewed
Mar 18, 2022
|
Also upgraded catalog datasource so org attribute is optional, so users can use from now on either the org at provider level or the one at datasource level. |
added 8 commits
March 25, 2022 10:27
Signed-off-by: Miguel Sama <[email protected]>
…of_media to catalog resource schema Signed-off-by: Miguel Sama <[email protected]>
…catalog datasource Signed-off-by: Miguel Sama <[email protected]>
…of_media to resource schema Add test for number_of_vapp_templates and number_of_media Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Remove owner from catalog resource due to issues with API Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
added 13 commits
March 25, 2022 10:33
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
…atasource one Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
mikeletux
force-pushed
the
catalog-properties
branch
from
7c5f9ca to
e6741a8
Compare
|
One more thing I would like to have: read part of setting values to the state of data source and source seems are very similar. We could make one function and reuse it. We have quite often that in our provider. |
added 2 commits
March 25, 2022 11:40
…e code twice in catalog resource and datasource Signed-off-by: Miguel Sama <[email protected]>
…e code twice in catalog resource and datasource Signed-off-by: Miguel Sama <[email protected]>
@vbauzysvmware Done! |
vbauzys
reviewed
Mar 25, 2022
vbauzys
approved these changes
Mar 25, 2022
added 3 commits
March 25, 2022 12:23
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
Signed-off-by: Miguel Sama <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address the enhancements proposed by @vbauzysvmware on github issue #365 .
Description
According to the issue above mentioned, 7 new computed fields have been added to
catalogresource and datasource.Detailed description
The new computed fields for
catalogresource and datasource are:catalog_version- Version number from this catalog.owner_name- Owner of the catalog.number_of_vapp_templates- Number of vApp templates available in this catalog.number_of_media- Number of media items available in this catalog.is_shared- Indicates if the catalog is shared.is_published- Indicates if this catalog is shared to all organizations.publish_subscription_type- Shows if the catalog is published, if it is a subscription from another one or none of those.This PR relays on vmware/go-vcloud-director#450