Add metadata support for Orgs and Disk resources/datasources

[adambarreiro]

Signed-off-by: abarreiro [email protected]

Depends on: vmware/go-vcloud-director#438

Description

This PR adds support for metadata maps in the vcd_org and vcd_independent_disk resources&datasources.

Extra

Refactored datasource_vcd_independent_disk, resource_vcd_independent_disk, datasource_vcd_org, resource_vcd_org to not use deprecated schema.Resource fields for create/update/delete/import, now it uses CreateContext, UpdateContext, ReadContext, DeleteContext.

Also in the above three items, functions return the diag.Diagnostics struct instead of plain Go errors, to adjust their signature to the new CreateContext, UpdateContext, ReadContext, DeleteContext fields.

[lvirbalas]

Where are the documentation additions for the new fields?

[Didainius]

Just as @lvirbalas mentioned - I am missing documentation of these fields in docs.

Code looks and worked great, as I tested with tags org and disk as well as manually while observing statefile. I am good to approve in general, just a few minor comments in code and I have an ask for tests - could add a few additional steps (for future insurance):

• Adding more than one key in the metadata block (I saw it is there for Org, but also could be for independent disk)
• Where we have test with multiple steps, you could use the opportunity to set metadata in one step and remove it in the next (with additional check that it is not set after that). That way we could have coverage if we ever screw up metadata cleanup.

[adambarreiro]

Added documentation updates for disk and org resources, and org datasource. Disk datasource didn't need to be changed, as it only references the resource.

[adambarreiro]

Just as @lvirbalas mentioned - I am missing documentation of these fields in docs.

Code looks and worked great, as I tested with tags org and disk as well as manually while observing statefile. I am good to approve in general, just a few minor comments in code and I have an ask for tests - could add a few additional steps (for future insurance):

• Adding more than one key in the metadata block (I saw it is there for Org, but also could be for independent disk)
• Where we have test with multiple steps, you could use the opportunity to set metadata in one step and remove it in the next (with additional check that it is not set after that). That way we could have coverage if we ever screw up metadata cleanup.

Added a new step to update metadata for Disks and Orgs. For Orgs I need to check further as I'm getting an error, so PR can't be merged as it's now.

[Didainius]

Added a new step to update metadata for Disks and Orgs. For Orgs I need to check further as I'm getting an error, so PR can't be merged as it's now.

Ok. We can sync up on that or I'll be waiting for a heads up.

[adambarreiro]

Added a new step to update metadata for Disks and Orgs. For Orgs I need to check further as I'm getting an error, so PR can't be merged as it's now.

Ok. We can sync up on that or I'll be waiting for a heads up.

Fixed in the last commit.

[adambarreiro]

I'm requesting a new review @Didainius @vbauzysvmware, as I merged code from main with #789 which was a quite big change. So far, disks tests pass, so it should be OK, but just in case you have new suggestions or things to improve.

[vbauzys]

now LGTM. Thank you

[Didainius]

LGTM - thanks

[mikeletux]

LGTM! Approved!

[vmwclabot]

@adambarreiro, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 5a8cbde must be signed by [email protected]

[vmwclabot]

@adambarreiro, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 5a8cbde must be signed by [email protected]

[adambarreiro]

Test pass, ready to merge once all conversations are solved.