Add VDC group support for NSX-T Edge Gateway #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
force-pushed
the
vdc-grp-pr
branch
2 times, most recently
from
cf7080a to
6136be6
Compare
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
force-pushed
the
vdc-grp-pr
branch
7 times, most recently
from
037826a to
68afac1
Compare
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
force-pushed
the
vdc-grp-pr
branch
from
68afac1 to
93cc7ce
Compare
Didainius
requested review from
lvirbalas,
dataclouder and
vbauzys
as code owners
lvirbalas
requested changes
Feb 28, 2022
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
reviewed
Mar 1, 2022
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
reviewed
Mar 1, 2022
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
force-pushed
the
vdc-grp-pr
branch
2 times, most recently
from
3eba566 to
1f89e90
Compare
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
approved these changes
Mar 9, 2022
terraform-provider-vcd-bot
added
test-running:acc
test-failed:acc
and removed
test-request:acc
test-running:acc
labels
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
adambarreiro
approved these changes
Mar 17, 2022
vbauzys
approved these changes
Mar 17, 2022
mikeletux
approved these changes
Mar 21, 2022
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for VDC Groups to NSX-T Edge Gateway resources and data sources
vcd_nsxt_edgegateway.VDC Group support requires VCD 10.2+ and API v35.0+.
The main difference is
types.OpenAPIEdgeGateway.OrgVdc.IDis deprecated and replaced bytypes.OpenAPIEdgeGateway.OwnerRef.IDwhich supports VDC Groups.Our resource has two new fields
owner_id(which supports VDC or VDC Group) andstarting_vdc_id. It also deprecatesvdcfield at resource level as well asproviderlevel.Note. NSX-T Edge Gateway cannot be created directly in VDC Group (it must at first be created in a VDC which is a member of VDC Group).
starting_vdc_idallows to (optionally) specify a VDC, in which the Edge Gateway should be created while the final destination will be what is specified inowner_id. Whenstarting_vdc_idis not specified, butowner_idis a VDC Group - this resource will pick random VDC in the group and then move Edge Gateway to it.The most ugly part here is backwards compatibility, migration path, and the field pick priority. Such field priority is meant to be set:
owner_id(ignores other values)vdcat resource levelvdcinherited fromprovidersectionDocs are adjusted accordingly and also all examples with using
vdcfield are removed.Additional things:
Minimally patched Org Network resources using OpenAPI (full VDC support to come out in other PR to
split cognitive load). The only change for now is VDC specification field switched from
OrgVdctoOwnerId. The reason is that API switched to V35.0 and OrgVdc ID cannot be created anymore (APIreturns error)
Changed a few MetadataFields from deprecated to new format, because staticcheck complains
Ran tests with tag
nsxton 10.2.2.1, 10.3.1