Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storage profile update #698

Merged
merged 11 commits into from
Aug 6, 2021
Merged

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Jul 28, 2021

In addition to the problem identified in Issue 648, this PR resolves the problem where storage profiles could be chosen from a Provider VDC different from the one that was chosen as parent for the Org VDC.

* Fix Issue vmware#648 adding a storage profile requires the vdc to be replaced
* Fix Issue vmware#696 Catalog deletion failure returns as success

Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder changed the title Fix storage profile update and catalog deletion Fix storage profile update Jul 28, 2021
Giuseppe Maxia added 2 commits July 28, 2021 11:38
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder marked this pull request as ready for review July 28, 2021 09:55
@dataclouder dataclouder requested a review from vbauzys July 28, 2021 10:27
.changes/v3.4.0/698-bug-fixes.md Show resolved Hide resolved
vcd/resource_vcd_org_vdc.go Show resolved Hide resolved
vcd/resource_vcd_org_vdc.go Show resolved Hide resolved
Giuseppe Maxia added 2 commits July 28, 2021 16:20
vcd/resource_vcd_org_vdc_nsxt_test.go Outdated Show resolved Hide resolved
vcd/org_vdc_common_test.go Show resolved Hide resolved
Signed-off-by: Giuseppe Maxia <[email protected]>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Giuseppe Maxia added 4 commits July 29, 2021 12:06
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder merged commit ae590e3 into vmware:master Aug 6, 2021
@dataclouder dataclouder deleted the update-vdc-storage branch November 20, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants