Include govcd with catalog regression fix for GetCatalogByName and GetCatalogById #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
force-pushed
the
v2.12.0_regression_fix
branch
from
40b3bf8 to
04b46c3
Compare
Didainius
force-pushed
the
v2.12.0_regression_fix
branch
from
04b46c3 to
a551681
Compare
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
force-pushed
the
v2.12.0_regression_fix
branch
from
a551681 to
5c6f7ac
Compare
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
dataclouder
approved these changes
Jul 4, 2021
lvirbalas
approved these changes
Jul 5, 2021
Signed-off-by: Dainius Serplis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #689
This PR should fix regression in Terraform provider VCD 3.3.0 where a catalog shared from another Org might not be found.
It also includes a test
TestAccVcdCatalogSharedAccesswhich triggers the bug in Org user mode (usingVCD_TEST_ORG_USERflag). One should tunego.mod(to consume go-vcloud-directorv2.12.0in and useVCD_TEST_ORG_USERmode to replicate this bug.)The test
TestAccVcdCatalogSharedAccessitself uses specific functionality in SDK to prepare the environment (new org, new vdc, a catalog with image and share it with existing org). This explicitly requiresSystemcredentials and additional functioncreateSystemTemporaryVCDConnectionwas introduced in test files. After the test run all these specific entities are cleaned up using SDK as well.