Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce NSX-T Application Port Profiles #673

Merged
merged 6 commits into from
Jun 11, 2021
Merged

Introduce NSX-T Application Port Profiles #673

merged 6 commits into from
Jun 11, 2021

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented May 25, 2021 •
edited
Loading

This PR introduces NSX-T Application Port Profile resource and data source.

Additionally:

@Didainius Didainius force-pushed the app-profiles-pr branch 7 times, most recently from 82986bb to 74fc614 Compare May 26, 2021 18:09
@Didainius Didainius self-assigned this May 26, 2021
@Didainius Didainius force-pushed the app-profiles-pr branch 6 times, most recently from 23dfe01 to 1197771 Compare May 27, 2021 09:03
@Didainius Didainius marked this pull request as ready for review May 27, 2021 12:51
lvirbalas
lvirbalas reviewed May 27, 2021
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just begun the review, but need to submit now to not lose the comments.

.changes/v3.3.0/673-improvements.md Outdated Show resolved Hide resolved
vcd/config_test.go Show resolved Hide resolved
@Didainius
Address comments
ade62ae 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius mentioned this pull request Jun 4, 2021
Merged
lvirbalas
lvirbalas reviewed Jun 9, 2021
View reviewed changes
.changes/v3.3.0/673-bug-fixes.md Outdated Show resolved Hide resolved
.changes/v3.3.0/673-improvements.md Outdated Show resolved Hide resolved
.changes/v3.3.0/673-bug-fixes.md Outdated Show resolved Hide resolved
vcd/datasource_vcd_nsxt_app_port_profile.go Outdated Show resolved Hide resolved
vcd/resource_vcd_nsxt_app_port_profile.go Show resolved Hide resolved
vcd/resource_vcd_nsxt_app_port_profile.go Outdated Show resolved Hide resolved
website/docs/d/nsxt_app_port_profile.html.markdown Outdated Show resolved Hide resolved
website/docs/d/nsxt_app_port_profile.html.markdown Outdated Show resolved Hide resolved
website/docs/r/nsxt_app_port_profile.html.markdown Outdated Show resolved Hide resolved
website/docs/r/nsxt_app_port_profile.html.markdown Outdated Show resolved Hide resolved
@Didainius
Address comments
cf5a725 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Address incorrect website docs
6bf87ee 
Signed-off-by: Dainius Serplis <[email protected]>
Didainius added 2 commits June 11, 2021 12:49
@Didainius
Merge master
6e04fe0 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Change govcd
d4dd674 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius merged commit 3cd972d into vmware:master Jun 11, 2021
@Didainius Didainius deleted the app-profiles-pr branch June 11, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

Assignees

@Didainius Didainius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: cannot support 1 CPUs using 2 cores per socket
3 participants
@Didainius @lvirbalas @dataclouder