Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of vApp name and description #664

Merged
merged 7 commits into from
Apr 30, 2021

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Apr 28, 2021

* vApp name is now updatable. Changing it doesn't force a resource rebuild. (reverted, because of possible side effects on VMs)

  • vApp description was ignored up to now. It was not added to new vApps or updated when requested. Now it can be inserted and changed.

Solves issue #633

Giuseppe Maxia added 2 commits April 28, 2021 16:53
@dataclouder dataclouder self-assigned this Apr 28, 2021
@dataclouder dataclouder marked this pull request as ready for review April 28, 2021 15:08
@dataclouder dataclouder changed the title Add handling of vapp name and description Add handling of vApp name and description Apr 28, 2021
Giuseppe Maxia added 3 commits April 29, 2021 10:37
Signed-off-by: Giuseppe Maxia <[email protected]>
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

One non impacting comment which could improve readability. Up to you to choose whether it should be fixed.

vcd/resource_vcd_vapp.go Outdated Show resolved Hide resolved
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder merged commit db8d6c9 into vmware:master Apr 30, 2021
@dataclouder dataclouder deleted the fix-vapp-description branch November 20, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants