Add NSX-T support for Org Vdc #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataclouder
approved these changes
Aug 27, 2020
lvirbalas
approved these changes
Sep 1, 2020
vcd/config_test.go
Outdated
| func skipNoNsxtConfiguration(t *testing.T) { | ||
| generalMessage := "Missing NSX-T config: " | ||
| if testConfig.VCD.NsxtProviderVdc.Name == "" { | ||
| t.Skip(generalMessage + "No provider vdc specified") |
There was a problem hiding this comment.
Suggested change
| t.Skip(generalMessage + "No provider vdc specified") | |
| t.Skip(generalMessage + "No provider VDC specified") |
There was a problem hiding this comment.
This was fixed. Didn't comment.
.changes/v2.10.0/550-features.md
Outdated
| @@ -0,0 +1 @@ | |||
| * Add support for NSX-T Org Vdc [GH-550] | |||
There was a problem hiding this comment.
I think it's better to use capital "VDC" in human-facing messages.
Suggested change
| * Add support for NSX-T Org Vdc [GH-550] | |
| * Add support for NSX-T Org VDC [GH-550] |
There was a problem hiding this comment.
This was fixed as well. Comment was missing.
vbauzys
approved these changes
Sep 16, 2020
vcd/org_vdc_shared_test.go
Outdated
| @@ -0,0 +1,335 @@ | |||
| // +build vdc nsxt ALL functional | |||
There was a problem hiding this comment.
maybe is better to rename file to something like vdc_util_test.go vdc_common_test.go to avoid opening/read this as normal/running test as others are with same naming convention.
There was a problem hiding this comment.
Renamed to vdc_common_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR plays on top of recent default API version bump to V32.0 and tests out that NSX-T backed Org Vdc can be created.
It also adds a test for NSX-T backed Org Vdc when NSX-T related configuration is specified in config.
Note Additional NSX-T related configuration is mandatory to run the test
TestAccVcdOrgVdcNsxt