Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve isolation of tagged tests #532

Merged
merged 6 commits into from
Jul 8, 2020

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Jul 7, 2020

  • Improved tagged tests to make sure they can run in isolation
  • Added a test to check tags isolation (runs with make test)
  • added command make tagverify to run the tags isolation test
$ make tagverify
=== RUN TagsTest
  --- PASS: TagsTest/ALL
  --- PASS: TagsTest/api
  --- PASS: TagsTest/auth
  --- PASS: TagsTest/binary
  --- PASS: TagsTest/catalog
  --- PASS: TagsTest/disk
  --- PASS: TagsTest/extnetwork
  --- PASS: TagsTest/functional
  --- PASS: TagsTest/gateway
  --- PASS: TagsTest/lb
  --- PASS: TagsTest/lbAppProfile
  --- PASS: TagsTest/lbAppRule
  --- PASS: TagsTest/lbServerPool
  --- PASS: TagsTest/lbServiceMonitor
  --- PASS: TagsTest/lbVirtualServer
  --- PASS: TagsTest/network
  --- PASS: TagsTest/org
  --- PASS: TagsTest/query
  --- PASS: TagsTest/search
  --- PASS: TagsTest/user
  --- PASS: TagsTest/vapp
  --- PASS: TagsTest/vdc
  --- PASS: TagsTest/vm
--- PASS: TagsTest (48s)

(Also removed vcd_org_group duplicated line from CHANGELOG)

Giuseppe Maxia added 2 commits July 7, 2020 10:44
@ghost ghost added the size/S label Jul 7, 2020
@ghost ghost added size/M and removed size/S labels Jul 7, 2020
@dataclouder dataclouder marked this pull request as ready for review July 7, 2020 08:59
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It passes for me.

@dataclouder dataclouder merged commit 5c36efa into vmware:master Jul 8, 2020
@dataclouder dataclouder deleted the improve-tagged-tests branch November 20, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants