Added options to configure dhcp lease times #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great. Are you able to commit the changes to the vendor files by running govendor fetch, as I have now merged UKCloud/govcloudair#8 ? Cheers |
|
Done. UKCloud/govcloudair@0f21764 also includes some unrelated changes regarding |
bobbydeveaux
approved these changes
Aug 21, 2017
|
Awesome thanks. CI suite running this now |
|
|
@bobbydeveaux Currently I've some issues creating a VM when using this version:
I'm still trying to find out what causes this issue. |
|
The issues I had are unrelated to the changes in this pull request. I'll create a separate issue for that. |
player-two
pushed a commit
to player-two/terraform-provider-vcd
that referenced
this pull request
Nov 6, 2018
Updates Issue vmware#47. The vendor directory includes our project direct dependencies (check.v1, yaml.v2) and a dependency of yaml (pretty). The vendor directory has been created using govendor (https://github.com/kardianos/govendor) The file vendor/vendor.json is the index. While it is not needed for builds, it will simplify future changes to the vendor folder. Signed-off-by: Giuseppe Maxia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to allow DHCP lease times to be configured, see UKCloud/govcloudair#8 for additional changes.