Add Edge Gateway DHCP relay configuration support #416
Conversation
ghost
added
|
|
||
| ip_addresses = ["1.1.1.1", "2.2.2.2"] | ||
| domain_names = ["servergroups.domainname.com", "other.domain.com"] | ||
| ip_sets = [vcd_ipset.myset1.name, vcd_ipset.myset2.name] |
There was a problem hiding this comment.
Thinking that it may be clearer for new users if we defined these IP set resources in this example as well.
| Type: schema.TypeSet, | ||
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
| "org_network": { |
There was a problem hiding this comment.
Two comments:
1.) It seems, in H5 UI in addition to Org networks you can select external network:
Are you sure it's only org networks?
2.) I'm also thinking whether we shouldn't rename org_network -> org_network_name for clarity. It would be similar to network_name in vcd_nsxv_snat resource.
3.) And continuing on the train of thought of (1) and (2), if it turns out that we can select external network, then we could just name the field network_name as in NAT rules.
There was a problem hiding this comment.
Two comments:
1.) It seems, in H5 UI in addition to Org networks you can select external network:
Are you sure it's only org networks?
Yes. It does allow to choose, but here is what happens:
2.) I'm also thinking whether we shouldn't rename
org_network->org_network_namefor clarity. It would be similar tonetwork_nameinvcd_nsxv_snatresource.
Can do. I kind of thought between this and that. In some places we don't ask for "name", in some we do. (like edge_gateway also asks for name, but we don't mention it).
3.) And continuing on the train of thought of (1) and (2), if it turns out that we can select external network, then we could just name the field
network_nameas in NAT rules.
I can make it broader - maybe in future it works although for my limited understanding this wouldn't make sense. The general point of relay is to "forward" DHCP request messages to defined servers outside of NSX. One shouldn't be able to forward DHCP request messages from external network. I might be wrong though.
There was a problem hiding this comment.
OK, so we have three choices:
org_networkorg_network_namenetwork_name
@Didainius @dataclouder @vbauzysvmware your votes?
To me network_name looks most consistent with the same field from NSX-V NAT rules. However, it doesn't reflect the point that these are only Org networks.
There was a problem hiding this comment.
network_name is more generic and will work even if we end up supporting different kinds of network
There was a problem hiding this comment.
I am fine with network_name
Didainius
force-pushed
the
vcd_dhcp_relay
branch
from
ad551c5 to
dfcd505
Compare
This PR adds support for NSX-V Edge Gateway DHCP relay configuration which represents relay DHCP relay configuration tab in edge gateway.
Note. This resource is a bit "special" because it actually does not create any objects and there is no real ID for it therefore there is a fake ID created which includes Edge Gateway ID and additional hardcoded string part.