-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add load balancing configuration for edge gateway #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes
@@ -17,8 +17,10 @@ Supported in provider *v2.4+* | |||
You must use `System Adminstrator` account in `provider` configuration | |||
and then provide `org` and `vdc` arguments for edge gateway to work. | |||
|
|||
~> **Note:** To enable load balancing capabilities the edge gateway must be `advanced`. Refer to | |||
[official vCloud Director documentation](https://docs.vmware.com/en/vCloud-Director/9.7/com.vmware.vcloud.tenantportal.doc/GUID-7E082E77-B459-4CE7-806D-2769F7CB5624.html) for more information. | |||
~> **Note:** Load balancing capabilities will work only when edge gateway is `advanced`. Load |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is broken: there is an extra newline between []
and ()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The make website
handles it. Link is active and working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then. It's only my IDE preview that complains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As part of load balancer introduction ( https://github.com/terraform-providers/terraform-provider-vcd/issues/223) this PR adds capability to set general load balancing settings (such as enable/disable load balancing)