Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load balancing configuration for edge gateway #288

Merged
merged 6 commits into from
Jul 25, 2019

Conversation

Didainius
Copy link
Collaborator

As part of load balancer introduction ( https://github.com/terraform-providers/terraform-provider-vcd/issues/223) this PR adds capability to set general load balancing settings (such as enable/disable load balancing)

vcd/resource_vcd_edgegateway.go Show resolved Hide resolved
vcd/resource_vcd_edgegateway.go Outdated Show resolved Hide resolved
website/docs/r/edgegateway.html.markdown Show resolved Hide resolved
Copy link
Contributor

@vbauzys vbauzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

vcd/resource_vcd_edgegateway.go Show resolved Hide resolved
@@ -17,8 +17,10 @@ Supported in provider *v2.4+*
You must use `System Adminstrator` account in `provider` configuration
and then provide `org` and `vdc` arguments for edge gateway to work.

~> **Note:** To enable load balancing capabilities the edge gateway must be `advanced`. Refer to
[official vCloud Director documentation](https://docs.vmware.com/en/vCloud-Director/9.7/com.vmware.vcloud.tenantportal.doc/GUID-7E082E77-B459-4CE7-806D-2769F7CB5624.html) for more information.
~> **Note:** Load balancing capabilities will work only when edge gateway is `advanced`. Load
Copy link
Contributor

@dataclouder dataclouder Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is broken: there is an extra newline between [] and ()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The make website handles it. Link is active and working.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then. It's only my IDE preview that complains

Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM now!

Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Didainius Didainius merged commit fc3dea2 into vmware:master Jul 25, 2019
@Didainius Didainius deleted the enable_lb branch August 13, 2019 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants