Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TM Edge Clusters and QoS #1375

Merged
merged 17 commits into from
Dec 20, 2024
Merged

TM Edge Clusters and QoS #1375

merged 17 commits into from
Dec 20, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Dec 16, 2024 •
edited
Loading

This PR adds the following

  • New Data Source: vcd_tm_edge_cluster to read and sync TM Edge Clusters
  • New Resource: vcd_tm_edge_cluster_qos to manage QoS settings for TM Edge Clusters
  • New Data Source: vcd_tm_edge_cluster_qos to read QoS settings for TM Edge Clusters

@Didainius
WIP
73e8f6d 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius force-pushed the regional-network-edge-clusters branch from 471d023 to 73e8f6d Compare December 17, 2024 05:51
@Didainius
WIP
f2819d0 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Testing
47408ec 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
docs hcl
5a45f66 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
docs hcl 2
fdc0ef6 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Improve docs
a06e6ae 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Self review, changelog
ea6c97a 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Bump sdk, self review, improve import and tests
e63133b 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Cleanup comments and empty spaces
0441cb0 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius marked this pull request as ready for review December 19, 2024 07:14
@Didainius Didainius changed the title TM Edge Clusters TM Edge Clusters and QoS Dec 19, 2024
@Didainius
Update requirements comment
b5c81ec 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Merge main, bump sdk
af3b7eb 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Fix typo
0c84306 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Fix broken merge
eca5027 
Signed-off-by: Dainius Serplis <[email protected]>
adambarreiro
adambarreiro approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test passed

vcd/validate_funcs.go Outdated Show resolved Hide resolved
website/docs/d/tm_edge_cluster.html.markdown Outdated Show resolved Hide resolved
@Didainius
Fix docs
214b766 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Improve validation
bf3a61a 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Bump sdk
a17d04f 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius merged commit b44a365 into vmware:main Dec 20, 2024
3 checks passed
@Didainius Didainius deleted the regional-network-edge-clusters branch December 20, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Didainius @adambarreiro @lvirbalas