Fix updating vcd_external_network_v2 with edge gateway having dedicate_external_network=true

[Didainius]

Closes #1183

About the problem

There is a bug in runtime validation that is triggered when all of the following conditions are met:

• User has external network backed by T0 or T0 VRF (aka provider gateway) without IP Spaces
• User has NSX-T edge gateway provisioned with flag dedicate_external_network = true
• User tries to update external network (e.g. expand the static_ip_pool) [this is when the bug described in Error: could not get network data: 'dedicated_org_id' modifying "vcd_external_network_v2" resource #1183 is hit]

Fix

The fix is to ignore validation !usingIpSpace && d.Get("dedicated_org_id").(string) != "" during update because d.Get("dedicated_org_id") might return the value of computed field which automatically gets populated when edge gateway consumes this network (has dedicate_external_network = true).

Sample hcl

resource "vcd_external_network_v2" "ext-net-nsxt" {
  name        = "XXX"
  description = "Test External Network"

  nsxt_network {
    nsxt_manager_id      = data.vcd_nsxt_manager.main.id
    nsxt_tier0_router_id = data.vcd_nsxt_tier0_router.router.id
  }

  use_ip_spaces = false

  ip_scope {
    enabled       = true
    gateway       = "192.168.30.49"
    prefix_length = "24"

    static_ip_pool {
      start_address = "192.168.30.51"
      end_address   = "192.168.30.66" # Increment the end address for update to see the issue
    }
  }

}


resource "vcd_nsxt_edgegateway" "nsxt-edge" {
  # org         = "my-org"
  owner_id    = data.vcd_org_vdc.vdc1.id
  name        = "nsxt-edge"
  description = "Description"

  external_network_id       = vcd_external_network_v2.ext-net-nsxt.id
  dedicate_external_network = true

  subnet {
    gateway       = "192.168.30.49"
    prefix_length = "24"
    primary_ip = "192.168.30.51"
    allocated_ips {
      start_address = "192.168.30.51"
      end_address   = "192.168.30.60"
    }
  }
}

Replicating

commit da78097 has a test that hits the issue

[adambarreiro]

Tricky computed attributes 🙂
LGTM, test passed

[lvirbalas]

Thank you!