Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non distributed network support for NSX-T Edge Gateway and routed network #1297

Merged
merged 11 commits into from
Aug 29, 2024
Merged

Add non distributed network support for NSX-T Edge Gateway and routed network #1297

merged 11 commits into from
Aug 29, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Jul 31, 2024 •
edited
Loading

Closes #1143

This PR adds support for NSX-T Non Distributed Org VDC networks via flags non_distributed_routing_enabled
in vcd_nsxt_edgegateway and interface_type=non_distributed in vcd_network_routed_v2

Didainius added 6 commits July 31, 2024 14:15
@Didainius
WIP: non distributed networks in Edge gateway and routed network
cdeda31 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Change go.mod
b304953 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add docs
a21190d 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add changelog
bcb9a84 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Bump sdk
90bd928 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Fix broken indentation
e3f863a 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius mentioned this pull request Aug 1, 2024
Closed
@Didainius Didainius marked this pull request as ready for review August 1, 2024 12:11
@ghost
Copy link

ghost commented Aug 2, 2024

Working great here !

adambarreiro
adambarreiro approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nsxt tests passed on 10.6

vcd/resource_vcd_network_routed_v2.go Outdated Show resolved Hide resolved
@Didainius
Improve field docs
c55a9ef 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Address comments
a385624 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Merge main
c123ae5 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Fix broken merge
1f5467e 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Merge main, bump sdk
639916e 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius merged commit f7fce0e into vmware:main Aug 29, 2024
3 checks passed
@Didainius Didainius deleted the issue-1143-non-distributed branch August 29, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vcd_network_routed_v2 doesn't have an interface_type NON_DISTRIBUTED (for NSX-T)
3 participants
@Didainius @adambarreiro @lvirbalas