Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution Add-On instance and publishing [3] #1272

Merged
merged 37 commits into from
Jun 25, 2024
Merged

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented May 23, 2024

This PR finalizes Solution Landing Zone support and adds resources and data sources vcd_solution_add_on_instance and vcd_solution_add_on_instance_publish that respectively allow to create Solution Add-On instances and publish those instances to tenants.

Testing

Testing this PR requires a build with CSE installed.

Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius force-pushed the slz3 branch 4 times, most recently from 209b8b7 to a5c1876 Compare June 19, 2024 08:48
Signed-off-by: Dainius Serplis <[email protected]>
go.mod Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius marked this pull request as ready for review June 20, 2024 08:49
go.mod Outdated Show resolved Hide resolved
vcd/resource_vcd_solution_add_on_instance.go Show resolved Hide resolved
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First scan, some doubts/small things

vcd/resource_vcd_solution_add_on_instance_test.go Outdated Show resolved Hide resolved
vcd/resource_vcd_solution_add_on_instance.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_solution_add_on_instance.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_solution_add_on_instance.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_solution_add_on_instance_publish.go Outdated Show resolved Hide resolved
vcd/resource_vcd_solution_add_on_instance.go Show resolved Hide resolved
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants