Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource to manage solution landing zone [1] #1251

Merged
merged 13 commits into from
May 17, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Apr 11, 2024

This is the first step towards adding support for solution add-on management in VCD using Terraform provider.
This particular PR adds one new resource and one data source vcd_solution_landing_zone that is responsible for configuring Solution Landing Zone (SLZ)

Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius changed the title WIP: Add resource to manage solution landing zone Add resource to manage solution landing zone Apr 15, 2024
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius marked this pull request as ready for review May 7, 2024 12:15
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! One comment inline.

vcd/datasource_vcd_solution_landing_zone.go Outdated Show resolved Hide resolved
.changes/v3.13.0/1251-features.md Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First scan

vcd/datasource_vcd_solution_landing_zone.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_solution_landing_zone.go Outdated Show resolved Hide resolved
website/docs/r/solution_landing_zone.html.markdown Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius changed the title Add resource to manage solution landing zone Add resource to manage solution landing zone [1] May 14, 2024
Didainius added 2 commits May 17, 2024 13:23
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius merged commit 5be38c1 into vmware:main May 17, 2024
3 checks passed
@Didainius Didainius deleted the pr-dse-landing branch May 17, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants