Add gateway service configuration to IP Space resource #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
requested review from
lvirbalas,
adambarreiro,
dataclouder and
adezxc
as code owners
adambarreiro
approved these changes
Nov 16, 2023
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
reviewed
Nov 17, 2023
lvirbalas
approved these changes
Nov 22, 2023
adezxc
approved these changes
Nov 22, 2023
dataclouder
approved these changes
Nov 22, 2023
Signed-off-by: Dainius Serplis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1137
This PR adds NAT and Firewall creation configuration to
vcd_ip_spaceresource and data source using fieldsdefault_firewall_rule_creation_enabled,default_no_snat_rule_creation_enabled,default_snat_rule_creation_enabledIP Space tests passed on 10.4.1, 10.4.2, 10.5.0. Also ran binary and upgrade tests