Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource and datasource vcd_nsxt_edgegateway_dns for DNS configuration management #1154

Merged
merged 32 commits into from
Nov 23, 2023
Merged

New resource and datasource vcd_nsxt_edgegateway_dns for DNS configuration management #1154

merged 32 commits into from
Nov 23, 2023

Conversation

adezxc
Copy link

@adezxc adezxc commented Nov 8, 2023 •
edited
Loading

Add new resource and data source for NSX-T Edge Gateway DNS configuration.

It is pretty straightforward except for a few caveats:
snat_rule_ip_address is only available since 10.5.1 and can only be set for IP-spaces enabled Edge Gateways
conditional_forwarder_zone is a set that contains another two sets upstream_servers and domain_names.

Adam Jasinski added 14 commits November 7, 2023 13:26
Define schema for the NSX-T Edge Gateway DNS resource
62f07a4 
Signed-off-by: Adam Jasinski <[email protected]>
Implement Terraform CRUD operations for the Edge Gateway DNS resource
d95b8d5 
Signed-off-by: Adam Jasinski <[email protected]>
Add datasource
b33a034 
Signed-off-by: Adam Jasinski <[email protected]>
Create tests for Edge Gateway DNS Feature
6de9ad4 
Signed-off-by: Adam Jasinski <[email protected]>
Start writing the docs for the DNS resource
7539487 
Signed-off-by: Adam Jasinski <[email protected]>
cherrypick testCheckResourceAttrSetWhenVersionMatches from abarreiro PR
3ec45f4 
Signed-off-by: Adam Jasinski <[email protected]>
Fix typos
1723e09 
Signed-off-by: Adam Jasinski <[email protected]>
Remove IP Spaces part of test due to complication of running
8dc2b0c 
Signed-off-by: Adam Jasinski <[email protected]>
finish documentation
636fd95 
Signed-off-by: Adam Jasinski <[email protected]>
go mod tidy
ca808b6 
Signed-off-by: Adam Jasinski <[email protected]>
Add changelog entry, update documentation, add vcd.erb entries
f438fe1 
Signed-off-by: Adam Jasinski <[email protected]>
Merge branch 'main' of https://github.com/vmware/terraform-provider-vcd…
a9a1048 
… into edgegateway_dns

Signed-off-by: Adam Jasinski <[email protected]>
update docs
5cd551d 
Signed-off-by: Adam Jasinski <[email protected]>
update docs
eeade67 
Signed-off-by: Adam Jasinski <[email protected]>
@adezxc adezxc marked this pull request as ready for review November 13, 2023 10:03
Didainius
Didainius reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments on the first readthrough

website/docs/d/nsxt_edgegateway_dns.html.markdown Outdated Show resolved Hide resolved
vcd/resource_vcd_nsxt_edgegateway_dns.go Outdated Show resolved Hide resolved
Adam Jasinski added 2 commits November 14, 2023 16:10
add vdc group test
a424cc7 
Signed-off-by: Adam Jasinski <[email protected]>
merge main
b030fe3 
Signed-off-by: Adam Jasinski <[email protected]>
adambarreiro
adambarreiro reviewed Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! First scan:

.changes/v3.11.0/1154-features.md Outdated Show resolved Hide resolved
vcd/datasource_vcd_nsxt_edgegateway_dns.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_nsxt_edgegateway_dns.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_nsxt_edgegateway_dns.go Outdated Show resolved Hide resolved
vcd/datasource_vcd_nsxt_edgegateway_dns.go Show resolved Hide resolved
Adam Jasinski added 4 commits November 15, 2023 17:06
Add tests for Vdc Group Edge Gateway and IP Spaces Edge gateways, fix a
9a7b067 
bug with Default Forwarder zones where ID wouldn't be passed

Signed-off-by: Adam Jasinski <[email protected]>
address comments, fix bugs
959c3a0 
Signed-off-by: Adam Jasinski <[email protected]>
update message
f6fac59 
Signed-off-by: Adam Jasinski <[email protected]>
update elevated version
e0cf5da 
Signed-off-by: Adam Jasinski <[email protected]>
Didainius
Didainius requested changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but I have a few queries after testing it around

vcd/resource_vcd_nsxt_edgegateway_dns.go Outdated Show resolved Hide resolved
website/docs/r/nsxt_edgegateway_dns.html.markdown Outdated Show resolved Hide resolved
vcd/resource_vcd_nsxt_edgegateway_dns_test.go Outdated Show resolved Hide resolved
website/docs/r/nsxt_edgegateway_dns.html.markdown Show resolved Hide resolved
Adam Jasinski added 4 commits November 17, 2023 03:02
fix things, skip tests, do stuff
2b02c13 
Signed-off-by: Adam Jasinski <[email protected]>
Make DatasourceNotFound test work, also add checks when setting data for
234d4bf 
the config

Signed-off-by: Adam Jasinski <[email protected]>
add nosec directive
dd52379 
Signed-off-by: Adam Jasinski <[email protected]>
Move nosec directive
50b3980 
Signed-off-by: Adam Jasinski <[email protected]>
Adam Jasinski added 3 commits November 17, 2023 14:30
fix re-create operation
9020b5a 
Signed-off-by: Adam Jasinski <[email protected]>
Change place of nosec directive
9827bea 
Signed-off-by: Adam Jasinski <[email protected]>
fix some bugs on datasource read
353dbe5 
Signed-off-by: Adam Jasinski <[email protected]>
Adam Jasinski added 2 commits November 17, 2023 17:12
adambarreiro
adambarreiro approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests passed

Adam Jasinski added 2 commits November 23, 2023 14:38
update go.mod
d0df04c 
Signed-off-by: Adam Jasinski <[email protected]>
merge main
0aa411d 
Signed-off-by: Adam Jasinski <[email protected]>
@adezxc adezxc merged commit 6cc4c0c into vmware:main Nov 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adezxc @adambarreiro @lvirbalas @dataclouder @Didainius