Add property upload_any_file to vcd_catalog_media
#1123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2023 21:35
Setting this property to true we can upload any file. The default, without using this property, only allows .ISO files Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
| @@ -65,3 +65,7 @@ require ( | |||
| google.golang.org/grpc v1.56.0 // indirect | |||
| google.golang.org/protobuf v1.30.0 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/vmware/go-vcloud-director/v2 => github.com/dataclouder/go-vcloud-director/v2 v2.17.0-alpha.3.0.20231001193006-c092d978c551 | |||
There was a problem hiding this comment.
Please remove this module replacement before you merge this PR,
once you completely finish your code changes and the PR is ready to be merged.
You don't need to resolve this conversation, it will be automatically removed once
go.mod is in a correct state.
Thanks! 😸
dataclouder
changed the title
upload_any_file to vcd_catalog_media
dataclouder
requested review from
lvirbalas,
Didainius,
adambarreiro and
adezxc
as code owners
lvirbalas
approved these changes
Oct 2, 2023
adambarreiro
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting this property to true we can upload any file. The default, without using this property, only allows .ISO filesReplaced by PR #1124