-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSX-T Segment Profile Template support #1120
NSX-T Segment Profile Template support #1120
Conversation
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
5aa5ae0
to
230ab9a
Compare
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass. There is a lot to examine yet, but I wanted to start giving you a heads up on my findings so dar
website/docs/r/nsxt_global_default_segment_profile_template.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/nsxt_global_default_segment_profile_template.html.markdown
Outdated
Show resolved
Hide resolved
vcd/resource_vcd_nsxt_global_default_segment_profile_template.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Dainius Serplis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second pass
website/docs/d/nsxt_segment_mac_discovery_profile.html.markdown
Outdated
Show resolved
Hide resolved
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, massive PR! Please find some polishing comments in-line.
website/docs/d/nsxt_global_default_segment_profile_template.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/nsxt_segment_mac_discovery_profile.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/nsxt_global_default_segment_profile_template.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First scan, I may have slipped things so I'm going for the second 😅
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second pass, looks good to me. Also ran all nsxt
tests on 10.5.0, all good!
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Segment profiles
Segment profiles include layer 2 configuration details for segments and segment ports. There are several types of segment profiles: IP discovery, MAC discovery, SpoofGuard, quality of service (QoS), and segment security. When you create a segment profile template, you can include only one segment profile of each type. For more details on each type of segment profile, see Segment Profiles in NSX Administration Guide.
About
https://docs.vmware.com/en/VMware-Cloud-Director/10.5/VMware-Cloud-Director-Service-Provider-Admin-Guide/GUID-60F90A6D-1DC6-4C21-A404-B002E71417EF.html
PR Layout
Total of 9 data sources and 4 resources, that can be split in 3 layers:
NSX-T Segment Profile Data Sources
Segment Profile Templates (resource and data source)
Segment Profile Templates are composed of Segment Profiles
Segment Profile configurations (resource and data source)
The following resources can set default segment profiles at different layers of VCD infrastructure. Each of the lower-level resource can override the higher-level resource
Deprecations
This PR deprecates
edge_cluster_id
field invcd_org_vdc
(and makes itComputed
in addition to beingOptional
) in favor of separate resourcevcd_org_vdc_nsxt_network_profile
because it uses a Network Profile endpoint and now VDC default Segment Profile Templates are also configured using that same endpoint. This will give a more granular management.