-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite partitioning #1110
Test suite partitioning #1110
Conversation
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
* Add ability of using third-party tests file * Standardize file names, using build number if available * Remove 'dry-run', as '-vcd-short' will achieve the same result * Create a sentinel file (containing exit code) at the end of the tests Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only there's no changelog entry.
Signed-off-by: Giuseppe Maxia <[email protected]>
Added |
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First few comments on a first look. I think it would be good to have a small paragraph about how to execute core functionality with bare hands (using newly introduced flags) in TESTING.md
.
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
Signed-off-by: Giuseppe Maxia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done a few runs on smaller set of tests and it worked - thanks!
Signed-off-by: Giuseppe Maxia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran a small subset of tests on my own machine and worked great! Thanks for this improvement
Experimental method to partition the tests from the acceptance test suite.
In short, it works this way: you run the test with two parameters:
-vcd-partitions=3
// this is the number of partitions-vcd-partition-node=1
// this is the identified of the current nodeIn the other two VCDs, you run the same command, but with
-vcd-partition-node=2
and-vcd-partition-node=3
. The tests get split in three parts, and each node gets one piece.The partitioning works by collecting the test names from the current directory, sorting them, and assigning a node number to each name, before the test starts. The operation should give the same result in every VCD, provided that all nodes work on the same branch and commit.
Prerequisites:
preTestCheck
andpostTestCheck
function callsPossible problems:
Possible enhancements:
Preparation for parallel handling
This feature would work better if a centralized process were to start all the nodes, and collect the results.
For this reason, the following features were added:
-vcd-partition-tests-file
with the name of the file containing the tests that will run in the current node. If such an option was provided, the node will not attempt to create its own list of tests