-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFW rule management resource vcd_nsxt_distributed_firewall_rule #1076
Conversation
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a magical feature! I have provided some "fresh eyes" thoughts.
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! The last open item I have is on naming #1076 (comment) , but it will depend on input from a wider audience.
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great PR!
Signed-off-by: Dainius Serplis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Closes #970
This PR introduces a new resource and data source
vcd_nsxt_distributed_firewall_rule
to manage Distributed firewall rules one by one. We already have a resourcevcd_nsxt_distributed_firewall
, but that one manages all rules at once and there is a request #970 to manage rules one by one.Notes
VdcGroup.CreateDistributedFirewallRule
. As a consequence - firewall rules will not be created in parallel, but instead one by one (as the resource will have locks).above_rule_id
field in the new resource to handle the firewall rule position during create operation.vcd_vdc_group
. This would make it very inconvenient to work with firewall rules using new resources (although possible by using data source and then fieldabove_rule_id
to put all firewall rules above). To make things more convenient,vcd_vdc_group
resource has a new flagremove_default_firewall_rule
that would remove the default firewall rule.Note for reviewers - the "internals" of resource are very similar to
vcd_nsxt_distributed_firewall
. There difference is here we don't have element nesting in aTypeSet
Patch for API V38.0
vcd_nsxt_app_port_profile
has a patch for similar diff errors in commit 38c907b: