Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider vdc resource #1073

Merged
merged 38 commits into from
Jul 12, 2023
Merged

Provider vdc resource #1073

merged 38 commits into from
Jul 12, 2023

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Jun 25, 2023 •
edited
Loading

Address Issue #326.

  • Add resource vcd_provider_vdc
  • Add data sources
    • vcd_resource_pool
    • vcd_network_pool

Testing:

go test -tags functional -run TestAccVcdResourceProviderVdc -vcd-add-provider -vcd-verbose -v -timeout 0
Connecting to https://xxxxxxxxx.com/api (version 10.5.0.21892695)
as user administrator@System (using password)
=== RUN   TestAccVcdResourceProviderVdc
step  0 - create
step  1 - rename
step  2 - rename back
step  3 - add resource pool and storage profile
step  4 - remove resource pool and storage profile
step  5 - disable provider VDC
step  6 - enable provider VDC
step  7 - import provider VDC
--- PASS: TestAccVcdResourceProviderVdc (133.89s)
PASS

Note: you need to have at least one free resource pool to test provider VDC creation, and at least two of them to test update.

Also fixes Issue #1066

Giuseppe Maxia added 4 commits June 25, 2023 21:51
Update govcd dependency
a080be2 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add resource pool samples to TestConfig
de44e99 
Signed-off-by: Giuseppe Maxia <[email protected]>
Extend datasource_vcd_nsxt_manager with more data
455cf3d 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add new resource and data sources
c87f8a5 
* resource vcd_provider_vdc
* data source vcd_network_pool
* data source vcd_resource_pool
* first test for vcd_provider_vdc

Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder self-assigned this Jun 25, 2023
Giuseppe Maxia added 19 commits July 2, 2023 20:40
Add generic function ObjectMap
fdfbe4a 
ObjectMap converts list of complex objects into lists of simpler ones

Signed-off-by: Giuseppe Maxia <[email protected]>
update govcd dependencies
25ae066 
Signed-off-by: Giuseppe Maxia <[email protected]>
WIP
613fbd8 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add full CRUD operations to provider VDC resource
bf98909 
Signed-off-by: Giuseppe Maxia <[email protected]>
Fix retrieval of resource pools
17fc3fc 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add docs for provider VDC resource
4850a14 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add docs for resource pool data source
a22da29 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add docs for network pool data source
d9ff6c6 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update docs
3de1df3 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update docs
ffd51d6 
Signed-off-by: Giuseppe Maxia <[email protected]>
Fix DataSourcesNotFound test for vcd_resource_pool
b031be2 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update datasource vcd_provider_vdc
19aa55e 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add leftovers removal for provider VDC
8a52b1a 
Signed-off-by: Giuseppe Maxia <[email protected]>
Improve Read for provider VDC resource
bf19be1 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add retrieval of resource pool by ID
965e3a7 
Signed-off-by: Giuseppe Maxia <[email protected]>
Remove unused extractIdsFromReferences
4e2eba3 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add full CRUD test for provider VDC
619c03e 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add changelog item
e99e09c 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update docs
2ebc68a 
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder marked this pull request as ready for review July 3, 2023 15:44
Fix provider VDC name in test
b282169 
Signed-off-by: Giuseppe Maxia <[email protected]>
Giuseppe Maxia added 2 commits July 4, 2023 07:59
Update docs with importing information
c438436 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add test comment
2d257cc 
Signed-off-by: Giuseppe Maxia <[email protected]>
Didainius
Didainius reviewed Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First scan - will dig more

vcd/resource_vcd_provider_vdc.go Show resolved Hide resolved
vcd/resource_vcd_provider_vdc.go Outdated Show resolved Hide resolved
vcd/resource_vcd_provider_vdc.go Outdated Show resolved Hide resolved
vcd/resource_vcd_provider_vdc.go Outdated Show resolved Hide resolved
vcd/resource_vcd_provider_vdc.go Show resolved Hide resolved
vcd/resource_vcd_provider_vdc.go Show resolved Hide resolved
vcd/resource_vcd_provider_vdc.go Show resolved Hide resolved
Giuseppe Maxia added 4 commits July 4, 2023 17:39
Bump govcd
9834415 
Signed-off-by: Giuseppe Maxia <[email protected]>
Didainius
Didainius approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have manually validated the creation process and also checked that the fields, that support update - could be updated. As well as Org VDC can be created based on this new pVdc

Giuseppe Maxia added 5 commits July 6, 2023 15:02
Add OrgVdc to the provider VDC creation test
2cd3402 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add missing import URL
612cf84 
Signed-off-by: Giuseppe Maxia <[email protected]>
Bump govcd
d5e5001 
Signed-off-by: Giuseppe Maxia <[email protected]>
Bump govcd
f1f658a 
Signed-off-by: Giuseppe Maxia <[email protected]>
Merge branch 'main' into provider-vdc
b81b9d0 
Signed-off-by: Giuseppe Maxia <[email protected]>
adezxc
adezxc approved these changes Jul 10, 2023
View reviewed changes
Copy link

@adezxc adezxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tried the resource/data sources manually on 10.5.0 and everything seems to work fine.

lvirbalas
lvirbalas requested changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such an awesome long waited feature! Adding suggestions for documentation in-line.

.changes/v3.10.0/1073-features.md Outdated Show resolved Hide resolved
website/docs/r/provider_vdc.html.markdown Outdated Show resolved Hide resolved
website/docs/r/provider_vdc.html.markdown Outdated Show resolved Hide resolved
website/docs/r/provider_vdc.html.markdown Outdated Show resolved Hide resolved
website/docs/r/provider_vdc.html.markdown Outdated Show resolved Hide resolved
website/docs/r/provider_vdc.html.markdown Outdated Show resolved Hide resolved
website/docs/r/provider_vdc.html.markdown Outdated Show resolved Hide resolved
website/docs/d/resource_pool.html.markdown Outdated Show resolved Hide resolved
website/docs/r/provider_vdc.html.markdown Outdated Show resolved Hide resolved
Update docs
1c0e0d1 
Signed-off-by: Giuseppe Maxia <[email protected]>
lvirbalas
lvirbalas approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you a great PR and polishes!

adambarreiro
adambarreiro approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Update govcd
d426824 
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder merged commit 91ac3bb into vmware:main Jul 12, 2023
@dataclouder dataclouder mentioned this pull request Jul 12, 2023
Closed
@dataclouder dataclouder deleted the provider-vdc branch November 20, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adezxc adezxc adezxc approved these changes

@Didainius Didainius Didainius approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees

@dataclouder dataclouder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dataclouder @adambarreiro @lvirbalas @Didainius @adezxc