Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vcd_ip_space resource and data source #1061

Merged
merged 19 commits into from
Jun 20, 2023
Merged

Add vcd_ip_space resource and data source #1061

merged 19 commits into from
Jun 20, 2023

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented May 30, 2023 •
edited
Loading

This PR starts addressing IP space needs as requested in #1008
It only adds resource and data source vcd_ip_space in this PR, while the next PRs will add an integration layer for other components.

other things

  • make fmt adds -s flag because make fmtcheck expects it
  • TestAccDataSourceNotFound/vcd_nsxt_firewall and TestAccDataSourceNotFound/vcd_nsxt_route_advertisement were broken and are fixed as part of this PR

Didainius added 7 commits May 30, 2023 14:13
@Didainius
vcd_ip_space
92372f5 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Remove unneeded files
e2ebad1 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add changelog
ba232c2 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Self review
ead8571 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Self review 2
b1f7947 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Self review 2
c667566 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Fix hcl in docs
adbf5f4 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius marked this pull request as ready for review May 31, 2023 06:37
@Didainius Didainius removed the request for review from lvirbalas May 31, 2023 06:41
@Didainius Didainius mentioned this pull request Jun 1, 2023
Merged
adambarreiro
adambarreiro reviewed Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First scan, just a few doubts

website/docs/d/ip_space.html.markdown Outdated Show resolved Hide resolved
website/docs/r/ip_space.html.markdown Outdated Show resolved Hide resolved
vcd/resource_vcd_ip_space_test.go Outdated Show resolved Hide resolved
vcd/resource_vcd_ip_space_test.go Outdated Show resolved Hide resolved
website/docs/r/ip_space.html.markdown Outdated Show resolved Hide resolved
vcd/datasource_vcd_ip_space.go Show resolved Hide resolved
adezxc
adezxc suggested changes Jun 5, 2023
View reviewed changes
vcd/resource_vcd_ip_space.go Show resolved Hide resolved
vcd/resource_vcd_ip_space.go Outdated Show resolved Hide resolved
vcd/resource_vcd_ip_space_test.go Outdated Show resolved Hide resolved
vcd/resource_vcd_ip_space_test.go Outdated Show resolved Hide resolved
vcd/resource_vcd_ip_space_test.go Outdated Show resolved Hide resolved
vcd/resource_vcd_ip_space_test.go Outdated Show resolved Hide resolved
vcd/resource_vcd_ip_space_test.go Outdated Show resolved Hide resolved
website/docs/r/ip_space.html.markdown Outdated Show resolved Hide resolved
Didainius added 7 commits June 8, 2023 15:34
@Didainius
Address comments 1
da23f7a 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Fix indentation
8a68041 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
terraform fmt on code snippets
dd0b1e8 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Address comments 2
e3a9dfb 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Newer govcd
66df9c6 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Merge main
794ed71 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Patch a few failing TestAccDataSourceNotFound subtests
ac6a3bf 
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
lvirbalas reviewed Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature! Please find few suggestions inline.

vcd/resource_vcd_ip_space.go Outdated Show resolved Hide resolved
vcd/resource_vcd_ip_space.go Outdated Show resolved Hide resolved
website/docs/r/ip_space.html.markdown Outdated Show resolved Hide resolved
website/docs/r/ip_space.html.markdown Outdated Show resolved Hide resolved
website/docs/r/ip_space.html.markdown Outdated Show resolved Hide resolved
@Didainius
Address comments
9bff623 
Signed-off-by: Dainius Serplis <[email protected]>
adezxc
adezxc approved these changes Jun 19, 2023
View reviewed changes
vcd/resource_vcd_ip_space.go Show resolved Hide resolved
adambarreiro
adambarreiro approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

Didainius added 2 commits June 20, 2023 09:26
@Didainius
merge main
1c788c3 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Add VCD version checks to skip tests
b071054 
Signed-off-by: Dainius Serplis <[email protected]>
dataclouder
dataclouder approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@dataclouder dataclouder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass in all versions.
LGTM

Didainius added 2 commits June 20, 2023 10:19
@Didainius
Put correct govcd version
9167d50 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius
Fix go.mod
d9724d6 
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius merged commit f7178a9 into vmware:main Jun 20, 2023
@Didainius Didainius deleted the ipspaces11 branch June 20, 2023 08:01
adezxc pushed a commit that referenced this pull request Oct 16, 2023
Edge Gateway L2 VPN Tunnel resource and datasource (#1121)
2767fed 
* **New Resource:** `vcd_nsxt_edgegateway_l2_vpn_tunnel` to manage Edge Gateway L2 VPN Tunnel sessions [GH-1061]
* **New Data Source:** `vcd_nsxt_edgegateway_l2_vpn_tunnel` to read Edge Gateway L2 VPN Tunnel sessions [GH-1061]

---------

Signed-off-by: Adam Jasinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adezxc adezxc adezxc approved these changes

@dataclouder dataclouder dataclouder approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Didainius @adambarreiro @lvirbalas @dataclouder @adezxc