-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DHCP Forwarding Resource and Data source #1056
Conversation
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First quick scan with an ask to improve dhcp resource docs.
Could you improve the DHCP doc sample for relay mode (this one https://registry.terraform.io/providers/vmware/vcd/latest/docs/resources/nsxt_network_dhcp#example-usage-3-routed-org-vdc-network-with-relay-mode) to include the vcd_nsxt_edgegateway_dhcp_forwarding
in the snippet
I couldn't at the time of making that doc because vcd_nsxt_edgegateway_dhcp_forwarding
was missing piece
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits/doubts/comments.
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request to elaborate the enabled
field corner case.
Also, please add more details to the PR description (front page). For example, you could add some screenshots from the UI to make it clearer to everyone who reads it the first time.
Thanks!
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few inline comments and one ask - could you improve the sample snippet in DHCP resource https://registry.terraform.io/providers/vmware/vcd/latest/docs/resources/nsxt_network_dhcp#example-usage-3-routed-org-vdc-network-with-relay-mode
We didn't have forwarding resource back when this snippet was introduced
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Summary
vcd_nsxt_edgegateway_dhcp_forwarding
- NSX-T Edge Gateway DHCP forwarding configurationlockParentVdcGroupOrEdgeGateway
to reduce duplicationDescription
Implement
vcd_nsxt_edgegateway_dhcp_forwarding
resource/datasource for NSX-T backed edgegateways, also with the PR, enables full management of DHCP in relay mode for router networks.