-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create vApp VM Security Tag Tests #1046
Conversation
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few initial comments.
-
The
vcd_security_tag
is not necessary to create tag directly onvcd_vapp_vm
orvcd_vm
. We need to test at least such cases:- Create a security tag only by
security_tags
field onvcd_vapp_vm
andvcd_vm
(to check if it worked - we could either plug in a govcd function, or add data sources of these resources and check their values as we need to validate data sources anyway) - Improve
TestAccVcdSecurityTag
by checking ifvcd_security_tag
field gets populated on avcd_vapp_vm
resource that is being used in the test - Check a scenario when you create a security tag on in
vcd_vapp_vm
and what happens when you delete that VM (is the tag removed completely or left as orphan without any VMs) - Check that once you create a tag using
security_tags
on a VM and then remove that field from vm definition - there is still a tag on that VM (this will require using govcd function, probablytestAccCheckSecurityTagOnVMCreated
can be reused)
- Create a security tag only by
-
We also need to add
vcd.ResourceSchema-vcd_vapp_vm.tf
andvcd.ResourceSchema-vcd_vm.tf
toskip-upgrade-tests.txt
because their schema has changed (security_tags
field added)
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
This PR introduces
security_tags
field tests ofvcd_vapp_vm
andvcd_vm
resources that got introduced in #1006