Add "reboot_vapp_on_removal" field to test's template #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Jasinski <[email protected]>
adezxc
requested review from
lvirbalas,
Didainius,
adambarreiro and
dataclouder
as code owners
Didainius
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
Thanks - tests passed.
You could add this PR to existing issue 1007
You would do it this way:
* Add `prefix_length` field to `vcd_vapp_network` as creating IPv6 vApp networks was not supported due to the lack of a suitable subnet representation (Issue #999) [GH-1007, GH-1031]
lvirbalas
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Did the test start failing after we introduced reboot_vapp_on_removal? If yes, I wonder why, as the parameter is optional?
https://registry.terraform.io/providers/vmware/vcd/latest/docs/resources/vapp_network#reboot_vapp_on_removal
p.s. Also, a nit: please capitalize the first word "Add ..." in the PR title :)
adezxc
changed the title
|
Signed-off-by: Adam Jasinski <[email protected]>
adambarreiro
approved these changes
Mar 27, 2023
lvirbalas
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR that adds
reboot_vapp_on_removal: Truefield to thetestAccCheckVappNetwork_basic_ipv6template as it caused the binary test to fail.