-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSX-T ALB Virtual Service Transparent mode and Pool Firewall Group membership (VCD 10.4.1+) #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irewall Group membership Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
changed the title
NSX-T ALB Virtual Service Transparent mode and Pool Firewall Group membership
NSX-T ALB Virtual Service Transparent mode and Pool Firewall Group membership (VCD 10.4.1+)
Mar 21, 2023
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
requested review from
lvirbalas,
adambarreiro,
dataclouder and
adezxc
as code owners
March 22, 2023 06:41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements, just a few doubts
adezxc
approved these changes
Mar 22, 2023
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
adambarreiro
approved these changes
Mar 23, 2023
dataclouder
reviewed
Mar 24, 2023
dataclouder
approved these changes
Mar 24, 2023
lvirbalas
reviewed
Mar 27, 2023
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
approved these changes
Mar 27, 2023
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues on ALB feature catchup (started in #996), where
vcd_nsxt_alb_settings
added support for Transparent mode.This PR adds two new things (both require VCD 10.4.1+):
vcd_nsxt_alb_virtual_service
support for Transparent mode (via fieldis_transparent_mode_enabled
)vcd_nsxt_alb_pool
Group membership viamember_group_id
field (members of ALB Pool can come from IP Set instead of being manually enabled)Note There is quite a list of prerequisites to enable Transparent mode for ALB Virtual Services now. They are well outlined in this blog post (section Transparent Load Balancing) however, I don't think it is worth putting it all in our docs as it may soon get outdated due to this being fresh technology. I also observed that errors are meaningful when creation fails due to missed requirements.
UI views
vcd_nsxt_alb_virtual_service
vcd_nsxt_alb_pool
Testing
Tested on 10.3.0, 10.3.3, 10.4.0, 10.4.1