-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ipv6 vApp network creation #1007
Conversation
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
@adezxc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
1 similar comment
@adezxc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
044a0c2
to
df0dcd4
Compare
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First comments
Putting this in draft as there is a bug related to updating vApp networks with DHCP. |
Signed-off-by: Adam Jasinski <[email protected]>
@adezxc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Signed-off-by: Adam Jasinski <[email protected]>
Description
This PR fixes bug of not being able to create ipv6 vApp networks, as there was no
prefix_length
field, onlynetmask
. With the addition ofprefix_length
,netmask
is also marked asDeprecated
as `prefix_length is more universal and can be used by both ipv4 and ipv6.Removes
netmask
field'sDefault
(255.255.255.0) due to Terraform's limitations when usingExactlyOneOf
orConflictsWith
together withDefault
. Because of this, users will be required to explicitly specifynetmask
in their.tf
files or Terraform will re-create the resource.All changes are related to
resourceVcdVappNetwork
Changes
prefix_length
toresourceVcdVappNetwork
ExactlyOneOf
to bothprefix_length
andnetmask
fields.Default
value ofnetmask
netmask
asDeprecated
as prefix length is supported by both ipv4 and ipv6.Testing
TestAccVcdVappNetwork_Isolated_ipv6
to test creation of ipv6 networks.