Add OpenAPI based vcd_network_routed_v2 resource and datasource for handling NSX-T and NSX-V routed networks
#628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lvirbalas
requested changes
Feb 2, 2021
vcd/resource_vcd_vapp_vm.go
Outdated
| @@ -1614,7 +1614,7 @@ func resourceVcdVAppVmDelete(d *schema.ResourceData, meta interface{}) error { | |||
| } | |||
|
|
|||
| log.Printf("[TRACE] Removing VM: %s", vm.VM.Name) | |||
|
|
|||
| // sleep() sad | |||
There was a problem hiding this comment.
Leftover from the other issue?
There was a problem hiding this comment.
Oops. Total leftover from troubleshooting another issue.
This was referenced Feb 5, 2021
dataclouder
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101
This PR add OpenAPI based
vcd_network_routed_v2resource and datasource for handling NSX-T and NSX-V routed networks.Note. It does not include DHCP pool definition, because this depends on backing network provider (NSX-V and/org NSX-T) therefore it will be two separate resources a bit later (NSX-V and NSX-T DHCP management).
Note. The tests does not yet include end to end flow (with VM, etc), but I have tested it manually. I will add it once we have all org networks and DHCP definitions in place.
Additionally:
make installwill usegit describe --tagsso that lightweight tags are also included in build version.lockParentEdgeGtwandunLockParentEdgeGtwbecause some older resources would acquire lock by name, but new resources acquire lock by Edge gateway ID. These functions are now smart enough to lookup ID when only name was passed. That way we can ensure new and older resources are able to share lock.VirtualQuantitytype frominttoint64(related to Error Refreshing Vapp after VM Creation #626)setCatalogStorageProfilefor tests as Terraform provider supportsstorage_profile_idwhen creating catalog to specify correct storage.make testto capture previously undetected errors