On read, extract sensitive data from state #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annakhm
reviewed
Oct 11, 2023
nsxt/resource_nsxt_transport_node.go
Outdated
| case model.EdgeNode__TYPE_IDENTIFIER: | ||
| elems := d.Get("edge_node").([]interface{}) | ||
| elem = elems[0].(map[string]interface{}) |
There was a problem hiding this comment.
This might not be present (and crush) with import command
ksamoray
force-pushed
the
xport_node_sensitive_data
branch
3 times, most recently
from
17a9921 to
173db5e
Compare
annakhm
approved these changes
Oct 13, 2023
NSX does not return sensitive data (e.g passwords) on GET operation, and therefore TF detects a diff. But as the schema.Resource object contains the credentials from the state, we can keep these intact and then the value will remain as is and stored again in the state. Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
xport_node_sensitive_data
branch
from
173db5e to
e777aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSX does not return sensitive data (e.g passwords) on GET operation, and therefore TF detects a diff.
But as the schema.Resource object contains the credentials from the state, we can keep these intact and then the value will remain as is and stored again in the state.
This is relevant to the transport_node resource as it contains multiple password attributes, which are as of now placed in empty maps during read - hence state values are ignored.