-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 3.3.2 release #984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annakhm
force-pushed
the
prepare-332-release
branch
from
September 22, 2023 17:14
96698bb
to
32682fa
Compare
/test-all |
CHANGELOG.md
Outdated
|
||
IMPROVEMENTS: | ||
* Support on-demand connection init in the provider. This behavior is controlled with `on_demand_connection` flag and is useful is NSX manager is not available at the time of plan/apply ([#948](https://github.com/vmware/terraform-provider-nsxt/pull/948)) | ||
* `resource/nsxt_policy_tier1_gateway`: Support `type` argument. This argument helps with auto-configuring route advertisiements and provides the user experience thai is consistent with UI on VMC ([#909](https://github.com/vmware/terraform-provider-nsxt/pull/909)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: s/thai/that
CHANGELOG.md
Outdated
BUG FIXES: | ||
* `resource/nsxt_policy_security_policy`, `resource/nsxt_policy_gateway_policy`, `resource/nsxt_policy_ids_policy`: Fix rule ordering issue by auto-assigning `sequence_number`. ([#967](https://github.com/vmware/terraform-provider-nsxt/pull/967)) | ||
* `resource/nsxt_policy_group`: Fix `group_type` assignment on VMC by using `node/version` API to determine underlying NSX version ([#970](https://github.com/vmware/terraform-provider-nsxt/pull/970)) | ||
* `resource/nsxt_nat_rule`: Fix the resource, that was broken on recent NSX versions, by replacing `nat_pass` property, which was removed from platform, with `firewall_match` ([#950](https://github.com/vmware/terraform-provider-nsxt/pull/950)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: ensure compatibility with NSX 4.1.0 and above by replacing removed 'nat_pass' property with 'firewall_match'
annakhm
force-pushed
the
prepare-332-release
branch
2 times, most recently
from
September 22, 2023 18:11
570bf5a
to
c1bc090
Compare
Signed-off-by: Anna Khmelnitsky <[email protected]>
annakhm
force-pushed
the
prepare-332-release
branch
from
September 22, 2023 18:13
c1bc090
to
784ffaa
Compare
salv-orlando
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.