Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in transport node resource #978

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix crash in transport node resource #978

merged 1 commit into from
Sep 21, 2023

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Sep 20, 2023

In addition, mark computed fields as such. to avoid non-empty diff problem. Sinsitive attributes (such as root_password) will be addressed in follow-up PR.

In addition, mark computed fields as such. to avoid non-empty
diff problem. Sinsitive attributes (such as `root_password`)
will be addressed in follow-up PR.

Signed-off-by: Anna Khmelnitsky <[email protected]>
@@ -157,6 +159,7 @@ func getNodeSchema(addlAttributes map[string]*schema.Schema, addExactlyOneOf boo
"ip_addresses": {
Type: schema.TypeList,
Optional: true,
Computed: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this. Is this field used by users to locate the node?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see what you mean. When read it back this field might contain more IP addresses.

@annakhm annakhm merged commit 9d06ea9 into master Sep 21, 2023
2 checks passed
@annakhm annakhm deleted the fix-transport-node branch August 10, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants